]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: zd1211rw: silence sparse warnings
authorJohannes Berg <johannes.berg@intel.com>
Fri, 23 Feb 2024 10:40:27 +0000 (11:40 +0100)
committerKalle Valo <kvalo@kernel.org>
Wed, 28 Feb 2024 11:37:23 +0000 (13:37 +0200)
This code wants to compare the obtained value, but as it also
has a special type for register addresses to find places doing
such compares and calculations wrong, we need explicit casts
here to silence sparse.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240223114023.976fcd59e97a.I0bba4ef7dc2847ce8ab5ec229149e1a09413b8b9@changeid
drivers/net/wireless/zydas/zd1211rw/zd_usb.c

index 8505d84eeed60ce9e79e2f76bd258527ebd68a0f..f3b567a13ded2a16a63d8fde83c1b6d1c685a3eb 100644 (file)
@@ -380,7 +380,7 @@ static inline void handle_regs_int(struct urb *urb)
        spin_lock_irqsave(&intr->lock, flags);
 
        int_num = le16_to_cpu(*(__le16 *)(urb->transfer_buffer+2));
-       if (int_num == CR_INTERRUPT) {
+       if (int_num == (u16)CR_INTERRUPT) {
                struct zd_mac *mac = zd_hw_mac(zd_usb_to_hw(urb->context));
                spin_lock(&mac->lock);
                memcpy(&mac->intr_buffer, urb->transfer_buffer,
@@ -416,7 +416,8 @@ out:
        spin_unlock_irqrestore(&intr->lock, flags);
 
        /* CR_INTERRUPT might override read_reg too. */
-       if (int_num == CR_INTERRUPT && atomic_read(&intr->read_regs_enabled))
+       if (int_num == (u16)CR_INTERRUPT &&
+           atomic_read(&intr->read_regs_enabled))
                handle_regs_int_override(urb);
 }