nvme-tcp: log TLS handshake failures at error level

Update the nvme_tcp_start_tls() function to use dev_err() instead of
dev_dbg() when a TLS error is detected. This ensures that handshake
failures are visible by default, aiding in debugging.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>

diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index d924008c39491fb109a3e529c79e6fec23dd34e7..9233f088fac8855430229ea1ae1529e6e412024f 100644 (file)
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -1745,9 +1745,14 @@ static int nvme_tcp_start_tls(struct nvme_ctrl *nctrl,
                        qid, ret);
                tls_handshake_cancel(queue->sock->sk);
        } else {
-               dev_dbg(nctrl->device,
-                       "queue %d: TLS handshake complete, error %d\n",
-                       qid, queue->tls_err);
+               if (queue->tls_err) {
+                       dev_err(nctrl->device,
+                               "queue %d: TLS handshake complete, error %d\n",
+                               qid, queue->tls_err);
+               } else {
+                       dev_dbg(nctrl->device,
+                               "queue %d: TLS handshake complete\n", qid);
+               }
                ret = queue->tls_err;
        }
        return ret;