Tue Nov 6 19:54:00 CET 2007 Jim Meyering <meyering@redhat.com>

        Avoid risk of format string abuse (also avoids gcc warnings).
        * src/util.c (ReportError): Use a literal "%s" format string.
        * src/remote_internal.c (server_error): Likewise.
        * src/qemu_conf.c (qemudReportError): Likewise.
        * acinclude.m4: Add -Wformat -Wformat-security to default
          list of warning flags, to warn about errors such as the
          above.

diff --git a/ChangeLog b/ChangeLog
index 511ed6a3b4aa3767b1c1b36a449b62abca229bc3..406edf62169f76fa8051a5c3e5953ce8e41d0e76 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+Tue Nov 6 19:54:00 CET 2007 Jim Meyering  <meyering@redhat.com>
+
+       Avoid risk of format string abuse (also avoids gcc warnings).
+       * src/util.c (ReportError): Use a literal "%s" format string.
+       * src/remote_internal.c (server_error): Likewise.
+       * src/qemu_conf.c (qemudReportError): Likewise.
+       * acinclude.m4: Add -Wformat -Wformat-security to default
+         list of warning flags, to warn about errors such as the
+         above.
+
 Tue Nov  6 17:24:16 CET 2007 Daniel Veillard <veillard@redhat.com>
 
        * src/xs_internals.c: patch from Chris Lalancette, forgot to

diff --git a/acinclude.m4 b/acinclude.m4
index 15bb7ff6c2a6c8a47bfee22a674c5f61d4592d10..8ec39209a2af17a5f681ffe522d3e0551ae4282c 100644 (file)
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -26,13 +26,13 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
         try_compiler_flags=""
        ;;
     minimum)
-       try_compiler_flags="-Wall $common_flags"
+       try_compiler_flags="-Wall -Wformat -Wformat-security $common_flags"
        ;;
     yes)
-       try_compiler_flags="-Wall -Wmissing-prototypes $common_flags"
+       try_compiler_flags="-Wall -Wformat -Wformat-security -Wmissing-prototypes $common_flags"
        ;;
     maximum|error)
-       try_compiler_flags="-Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith"
+       try_compiler_flags="-Wall -Wformat -Wformat-security -Wmissing-prototypes -Wnested-externs -Wpointer-arith"
        try_compiler_flags="$try_compiler_flags -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return"
        try_compiler_flags="$try_compiler_flags -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare"
        try_compiler_flags="$try_compiler_flags $common_flags"

diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index 78f46996ee472bf0a13e2b2c62257adced962682..3556a9a0473ef6cb699f19c55f1738822f9cfa62 100644 (file)
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
@@ -64,7 +64,7 @@ void qemudReportError(virConnectPtr conn,
         errorMessage[0] = '\0';
     }
     __virRaiseError(conn, dom, net, VIR_FROM_QEMU, code, VIR_ERR_ERROR,
-                    NULL, NULL, NULL, -1, -1, errorMessage);
+                    NULL, NULL, NULL, -1, -1, "%s", errorMessage);
 }
 
 int qemudLoadDriverConfig(struct qemud_driver *driver,

diff --git a/src/remote_internal.c b/src/remote_internal.c
index 3af326fd3a49ea3b5ad87b91a18b816bbc87777e..1420a889fc4990628d33157225fa0af4c64236e4 100644 (file)
--- a/src/remote_internal.c
+++ b/src/remote_internal.c
@@ -3073,7 +3073,7 @@ server_error (virConnectPtr conn, remote_error *err)
                      err->domain, err->code, err->level,
                      str1, str2, str3,
                      err->int1, err->int2,
-                     message);
+                     "%s", message);
 }
 
 /* get_nonnull_domain and get_nonnull_network turn an on-wire

diff --git a/src/util.c b/src/util.c
index eb5785990e37a0c1ebc03da84f198fca04dd9ae8..c964a6355c63fb9be285a7bb7ce40fd64fee4341 100644 (file)
--- a/src/util.c
+++ b/src/util.c
@@ -53,7 +53,7 @@ ReportError(virConnectPtr conn,
         errorMessage[0] = '\0';
     }
     __virRaiseError(conn, dom, net, VIR_FROM_NONE, code, VIR_ERR_ERROR,
-                    NULL, NULL, NULL, -1, -1, errorMessage);
+                    NULL, NULL, NULL, -1, -1, "%s", errorMessage);
 }
 
 static int virSetCloseExec(int fd) {