]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
x86: Only align destination to 1x VEC_SIZE in memset 4x loop
authorNoah Goldstein <goldstein.w.n@gmail.com>
Wed, 1 Nov 2023 20:30:26 +0000 (15:30 -0500)
committerSunil K Pandey <skpgkp2@gmail.com>
Fri, 10 Jan 2025 01:23:28 +0000 (17:23 -0800)
Current code aligns to 2x VEC_SIZE. Aligning to 2x has no affect on
performance other than potentially resulting in an additional
iteration of the loop.
1x maintains aligned stores (the only reason to align in this case)
and doesn't incur any unnecessary loop iterations.
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
(cherry picked from commit 9469261cf1924d350feeec64d2c80cafbbdcdd4d)

sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S

index 3d9ad49cb91c37cf47ad92c6b00ad1448ddf0484..0f0636b90f8acf1bed46d614d2fbaf0c12f986d2 100644 (file)
@@ -293,7 +293,7 @@ L(more_2x_vec):
        leaq    (VEC_SIZE * 4)(%rax), %LOOP_REG
 #endif
        /* Align dst for loop.  */
-       andq    $(VEC_SIZE * -2), %LOOP_REG
+       andq    $(VEC_SIZE * -1), %LOOP_REG
        .p2align 4
 L(loop):
        VMOVA   %VMM(0), LOOP_4X_OFFSET(%LOOP_REG)