]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: caam - fix unchecked return value error
authorGaurav Jain <gaurav.jain@nxp.com>
Tue, 8 Aug 2023 10:55:25 +0000 (12:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:33 +0000 (12:22 +0200)
[ Upstream commit e30685204711a6be40dec2622606950ccd37dafe ]

error:
Unchecked return value (CHECKED_RETURN)
check_return: Calling sg_miter_next without checking return value

fix:
added check if(!sg_miter_next)

Fixes: 8a2a0dd35f2e ("crypto: caam - strip input zeros from RSA input buffer")
Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/caam/caampkc.c

index 88672757671012023ff08c29cde3ea61df066cba..51b48b57266a65cf0ba0ee51d105a42992ce59cf 100644 (file)
@@ -223,7 +223,9 @@ static int caam_rsa_count_leading_zeros(struct scatterlist *sgl,
                if (len && *buff)
                        break;
 
-               sg_miter_next(&miter);
+               if (!sg_miter_next(&miter))
+                       break;
+
                buff = miter.addr;
                len = miter.length;