Make static analyzer happier.

diff --git a/src/lib-storage/index/index-thread-finish.c b/src/lib-storage/index/index-thread-finish.c
index a5ddfb2fa56b761e9b7dd054e428bf052ee98ddf..7c18c18360e7d9156ca401eb9f1ae09fa8d0c222 100644 (file)
--- a/src/lib-storage/index/index-thread-finish.c
+++ b/src/lib-storage/index/index-thread-finish.c
@@ -650,11 +650,9 @@ mail_thread_iterate_next(struct mail_thread_iterate_context *iter,
                return NULL;
 
        child = &children[iter->next_idx++];
-       if (child_iter_r != NULL) {
-               shadow = array_idx(&iter->ctx->shadow_nodes, child->idx);
-               *child_iter_r = shadow->first_child_idx == 0 ? NULL :
-                       mail_thread_iterate_children(iter, child->idx);
-       }
+       shadow = array_idx(&iter->ctx->shadow_nodes, child->idx);
+       *child_iter_r = shadow->first_child_idx == 0 ? NULL :
+               mail_thread_iterate_children(iter, child->idx);
        if (child->uid == 0 && *child_iter_r == NULL) {
                /* this is a dummy node without children,
                   there's no point in returning it */