]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netxen_nic: Fix an error handling path in 'netxen_nic_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 12 Jun 2021 12:53:12 +0000 (14:53 +0200)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:49:33 +0000 (08:49 -0400)
[ Upstream commit 49a10c7b176295f8fafb338911cf028e97f65f4d ]

If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: e87ad5539343 ("netxen: support pci error handlers")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c

index f5fc0c416e510eb695deb11333c878bce9b9ee57..f89441f9bd8d128b2d08481c6ace1e28de3dbffc 100644 (file)
@@ -1616,6 +1616,8 @@ err_out_free_netdev:
        free_netdev(netdev);
 
 err_out_free_res:
+       if (NX_IS_REVISION_P3(pdev->revision))
+               pci_disable_pcie_error_reporting(pdev);
        pci_release_regions(pdev);
 
 err_out_disable_pdev: