]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
stupid coverity
authorAlan T. DeKok <aland@freeradius.org>
Wed, 31 May 2017 17:02:43 +0000 (13:02 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Wed, 31 May 2017 17:02:43 +0000 (13:02 -0400)
doesn't realize that returning in a failure case with the mutex
unlocked, means that the mutex is unlocked

CID #1206498

src/modules/rlm_sql/sql.c

index 6e21c3bdc11e2fa03c970a84c36f479376a13c46..dc4eea7640ee5ac9741b8fa337f603bcbcc62ad3 100644 (file)
@@ -545,6 +545,7 @@ void rlm_sql_query_log(rlm_sql_t const *inst, REQUEST *request, sql_acct_section
                ERROR("Couldn't open logfile '%s': %s", expanded, fr_syserror(errno));
 
                talloc_free(expanded);
+               /* coverity[missing_unlock] */
                return;
        }