]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/vf: fix return type in vf_migration_init_late()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 5 Dec 2025 11:10:31 +0000 (14:10 +0300)
committerMichał Winiarski <michal.winiarski@intel.com>
Wed, 17 Dec 2025 13:01:51 +0000 (14:01 +0100)
The vf_migration_init_late() function is supposed to return zero on
success and negative error codes on failure.  The error code
eventually gets propagated back to the probe() function and returned.
The problem is it's declared as type bool so it returns true on
error.  Change it to type int instead.

Fixes: 2e2dab20dd66 ("drm/xe/vf: Enable VF migration only on supported GuC versions")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Link: https://patch.msgid.link/aTK9pwJ_roc8vpDi@stanley.mountain
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
drivers/gpu/drm/xe/xe_sriov_vf.c

index 86423a799d579b3f837c79a5aee003eee542515f..1b75405b8d02774ec65aef3677074fe51910fac4 100644 (file)
@@ -226,7 +226,7 @@ void xe_sriov_vf_init_early(struct xe_device *xe)
        vf_migration_init_early(xe);
 }
 
-static bool vf_migration_init_late(struct xe_device *xe)
+static int vf_migration_init_late(struct xe_device *xe)
 {
        struct xe_gt *gt = xe_root_mmio_gt(xe);
        struct xe_uc_fw_version guc_version;