]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
lmdbbackend: Prevent a useless copy in LMDBBackend::getAllDomainsFiltered()
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 1 Aug 2023 11:49:50 +0000 (13:49 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 1 Aug 2023 11:49:50 +0000 (13:49 +0200)
Reported by Coverity as 1510936: AUTO_CAUSES_COPY.

modules/lmdbbackend/lmdbbackend.cc

index d47904815d52035b4153f0fc2542cde0502ad3bd..11168f326677286c845a9c1df00daaea830f8377 100644 (file)
@@ -1722,9 +1722,9 @@ void LMDBBackend::getAllDomainsFiltered(vector<DomainInfo>* domains, const std::
       zonemap[di.zone] = di;
     }
 
-    for (auto [k, v] : zonemap) {
+    for (auto& [k, v] : zonemap) {
       if (allow(v)) {
-        domains->push_back(v);
+        domains->push_back(std::move(v));
       }
     }
   }