Fix missing mutex destroy and ede invalidate on fctx_create() error paths

The error cleanup in fctx_create() was missing isc_mutex_destroy() and
dns_ede_invalidate() calls. When error paths (cleanup_nameservers,
cleanup_fcount, cleanup_qmessage, cleanup_adb) were taken after the
mutex and edectx were initialized, the fctx memory was freed without
properly destroying these resources first.

diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c
index 20763e612c41d349fce07c245cb99e110c6bda4e..a708bd0f0b109aba0a041b35b4685487a0fa6a64 100644 (file)
--- a/lib/dns/resolver.c
+++ b/lib/dns/resolver.c
@@ -5121,6 +5121,8 @@ cleanup_nameservers:
                fetchctx_detach(&fctx->parent);
        }
 
+       dns_ede_invalidate(&fctx->edectx);
+       isc_mutex_destroy(&fctx->lock);
        dns_resolver_detach(&fctx->res);
        isc_mem_putanddetach(&fctx->mctx, fctx, sizeof(*fctx));