]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
x86: Fix value for `x86_memset_non_temporal_threshold` when it is undesirable
authorNoah Goldstein <goldstein.w.n@gmail.com>
Fri, 14 Jun 2024 18:01:58 +0000 (13:01 -0500)
committerNoah Goldstein <goldstein.w.n@gmail.com>
Fri, 14 Jun 2024 22:25:05 +0000 (17:25 -0500)
When we don't want to use non-temporal stores for memset, we set
`x86_memset_non_temporal_threshold` to SIZE_MAX.

The current code, however, we using `maximum_non_temporal_threshold`
as the upper bound which is `SIZE_MAX >> 4` so we ended up with a
value of `0`.

Fix is to just use `SIZE_MAX` as the upper bound for when setting the
tunable.
Tested-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
sysdeps/x86/dl-cacheinfo.h

index d2fe61b9973fb330c67e830e03eebc4994441a71..3a6ec4ef9f787e2fc439702985af9cafd1988640 100644 (file)
@@ -1044,9 +1044,9 @@ dl_init_cacheinfo (struct cpu_features *cpu_features)
   TUNABLE_SET_WITH_BOUNDS (x86_non_temporal_threshold, non_temporal_threshold,
                           minimum_non_temporal_threshold,
                           maximum_non_temporal_threshold);
-  TUNABLE_SET_WITH_BOUNDS (
-      x86_memset_non_temporal_threshold, memset_non_temporal_threshold,
-      minimum_non_temporal_threshold, maximum_non_temporal_threshold);
+  TUNABLE_SET_WITH_BOUNDS (x86_memset_non_temporal_threshold,
+                          memset_non_temporal_threshold,
+                          minimum_non_temporal_threshold, SIZE_MAX);
   TUNABLE_SET_WITH_BOUNDS (x86_rep_movsb_threshold, rep_movsb_threshold,
                           minimum_rep_movsb_threshold, SIZE_MAX);
   TUNABLE_SET_WITH_BOUNDS (x86_rep_stosb_threshold, rep_stosb_threshold, 1,