]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amdgpu: keep irq count in amdgpu_irq_disable_all
authorGuchun Chen <guchun.chen@amd.com>
Thu, 25 May 2023 09:24:31 +0000 (17:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Aug 2023 15:32:55 +0000 (17:32 +0200)
commit 8ffd6f0442674f32c048ec8dffdbc5ec67829beb upstream.

This can clean up all irq warnings because of unbalanced
amdgpu_irq_get/put when unplugging/unbinding device, and leave
irq count decrease in each ip fini function.

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c

index fafebec5b7b66da8911ffb2f112817a1f1f626ae..9581c020d815d49e002af0dcd2c4024829036508 100644 (file)
@@ -124,7 +124,6 @@ void amdgpu_irq_disable_all(struct amdgpu_device *adev)
                                continue;
 
                        for (k = 0; k < src->num_types; ++k) {
-                               atomic_set(&src->enabled_types[k], 0);
                                r = src->funcs->set(adev, src, k,
                                                    AMDGPU_IRQ_STATE_DISABLE);
                                if (r)