]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: SDCA: Check devm_mutex_init() return value
authorStephen Rothwell <sfr@canb.auug.org.au>
Tue, 22 Jul 2025 10:27:54 +0000 (11:27 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 22 Jul 2025 11:20:42 +0000 (12:20 +0100)
Fix interaction with commit daec29dcc873 ("locking/mutex: Mark
devm_mutex_init() as __must_check"), add return value check. There is no
need for additional complex error handling here, failure to init the
mutex means the code can't progress, so the failure just needs to be passed
up to the caller.

Fixes: b126394d9ec6 ("ASoC: SDCA: Generic interrupt support")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20250722102754.2514351-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdca/sdca_interrupts.c

index b76512732af874d7a1fb508606298233d63aeb43..d442ba2f56816a97445868923c57c5da9d4d7d8a 100644 (file)
@@ -419,7 +419,9 @@ struct sdca_interrupt_info *sdca_irq_allocate(struct device *dev,
 
        info->irq_chip = sdca_irq_chip;
 
-       devm_mutex_init(dev, &info->irq_lock);
+       ret = devm_mutex_init(dev, &info->irq_lock);
+       if (ret)
+               return ERR_PTR(ret);
 
        ret = devm_regmap_add_irq_chip(dev, regmap, irq, IRQF_ONESHOT, 0,
                                       &info->irq_chip, &info->irq_data);