]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: rtw89: fw: Remove "const" on allocation type
authorKees Cook <kees@kernel.org>
Sat, 26 Apr 2025 06:09:36 +0000 (23:09 -0700)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 5 May 2025 01:35:56 +0000 (09:35 +0800)
In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct rtw89_reg2_def *" but the returned type,
while technically matching, will be const qualified. As there isn't a
general way to discard "const" qualifiers, adjust the returned type to
match the assigned type. No change in allocation size results.

Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250426060935.work.049-kees@kernel.org
drivers/net/wireless/realtek/rtw89/fw.c

index 4173794e38920f95bc02bfc9ec3706eca6f68d28..ba771a95b1cbc36b1e8359113924f938af399d46 100644 (file)
@@ -1021,7 +1021,7 @@ int rtw89_build_phy_tbl_from_elm(struct rtw89_dev *rtwdev,
        }
 
        n_regs = le32_to_cpu(elm->size) / sizeof(tbl->regs[0]);
-       regs = kcalloc(n_regs, sizeof(tbl->regs[0]), GFP_KERNEL);
+       regs = kcalloc(n_regs, sizeof(*regs), GFP_KERNEL);
        if (!regs)
                goto out;