]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Check return of OSSL_PROVIDER_do_all to avoid coverity noise
authorViktor Dukhovni <openssl-users@dukhovni.org>
Sat, 18 Jan 2025 07:34:54 +0000 (18:34 +1100)
committerViktor Dukhovni <openssl-users@dukhovni.org>
Tue, 21 Jan 2025 06:25:22 +0000 (17:25 +1100)
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26462)

apps/list.c

index c0b0a5a4c4322202f08496f2bd9b5ff3a5bcecdc..944722e78f2bb50ba8a7bd138180b2f5a60fbb24 100644 (file)
@@ -789,8 +789,9 @@ static void list_tls_signatures(void)
         OPENSSL_free(builtin_sigalgs);
     }
 
-    /* As built-in providers don't have this capability, never error */
-    OSSL_PROVIDER_do_all(NULL, list_tls_sigalg_caps, &tls_sigalg_listed);
+    if (!OSSL_PROVIDER_do_all(NULL, list_tls_sigalg_caps, &tls_sigalg_listed))
+        BIO_printf(bio_err,
+                   "ERROR: could not list all provider signature algorithms\n");
     if (tls_sigalg_listed < 2)
         BIO_printf(bio_out,
                    "\nNo TLS sig algs registered by currently active providers");