]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/dp: Drop call to intel_panel_fixed_mode() from compute_config
authorAnkit Nautiyal <ankit.k.nautiyal@intel.com>
Thu, 30 Apr 2026 13:12:20 +0000 (18:42 +0530)
committerAnkit Nautiyal <ankit.k.nautiyal@intel.com>
Mon, 11 May 2026 04:20:57 +0000 (09:50 +0530)
At the moment, in intel_dp_compute_config(), intel_panel_fixed_mode() is
called to check if the panel has any fixed mode or not. If it is an eDP
and has the fixed mode, then intel_panel_compute_config() is called.

However, the intel_panel_compute_config already checks if the panel
supports a fixed mode and returns early if it doesn't. This makes the
earlier check in the caller redundant.
Remove this extra check for intel_panel_fixed_mode().

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
Link: https://patch.msgid.link/20260430131220.3891497-6-ankit.k.nautiyal@intel.com
drivers/gpu/drm/i915/display/intel_dp.c

index 77791845d5dae99f664a2715f5db361611073d82..450098e08faa8388ec1862bd953a4dc42ba2d019 100644 (file)
@@ -3589,12 +3589,10 @@ intel_dp_compute_config(struct intel_encoder *encoder,
        struct intel_atomic_state *state = to_intel_atomic_state(conn_state->state);
        struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode;
        struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
-       const struct drm_display_mode *fixed_mode;
        struct intel_connector *connector = intel_dp->attached_connector;
        int ret = 0, link_bpp_x16;
 
-       fixed_mode = intel_panel_fixed_mode(connector, adjusted_mode);
-       if (intel_dp_is_edp(intel_dp) && fixed_mode) {
+       if (intel_dp_is_edp(intel_dp)) {
                ret = intel_panel_compute_config(connector, adjusted_mode);
                if (ret)
                        return ret;