efi_loader: add missing check in FMP.GetImageInfo()

The UEFI 2.11 specification, chapter 23.1.3 requires
EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo() to return
EFI_INVALID_PARAMETER if *ImageInfoSize is not too small
and ImageInfo is NULL.

Fixes: f27c20148511 ("efi_loader: add firmware management protocol for FIT image")
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

diff --git a/lib/efi_loader/efi_firmware.c b/lib/efi_loader/efi_firmware.c
index 75501e21557577c00f561d8f1a00c16fa388b56b..216df83de6757cb6ac0f0ff28c00436751756b5e 100644 (file)
--- a/lib/efi_loader/efi_firmware.c
+++ b/lib/efi_loader/efi_firmware.c
@@ -332,6 +332,8 @@ static efi_status_t efi_fill_image_desc_array(
 
                return EFI_BUFFER_TOO_SMALL;
        }
+       if (!image_info)
+               return EFI_INVALID_PARAMETER;
        *image_info_size = total_size;
 
        ret = efi_gen_capsule_guids();