maint: fix heap manipulations in previous commit

* src/sort.c (main): Ensure we don't free() and invalid
pointer when reading implicit stdin.  Also avoid
"definitely lost" valgrind warnings in the --files0-from case.

diff --git a/src/sort.c b/src/sort.c
index a7eda8325ac31235f07a9a94633591784642397f..7ce059282a0ccaedb5f3f7a29d6cc9438fbdd8d0 100644 (file)
--- a/src/sort.c
+++ b/src/sort.c
@@ -4681,10 +4681,10 @@ main (int argc, char **argv)
 
   if (nfiles == 0)
     {
-      static char *minus = (char *) "-";
       nfiles = 1;
       free (files);
-      files = −
+      files = xmalloc (sizeof *files);
+      *files = (char *) "-";
     }
 
   /* Need to re-check that we meet the minimum requirement for memory
@@ -4742,7 +4742,12 @@ main (int argc, char **argv)
       sort (files, nfiles, outfile, nthreads);
     }
 
-  IF_LINT (free (files));
+#ifdef lint
+  if (files_from)
+    readtokens0_free (&tok);
+  else
+    free (files);
+#endif
 
   if (have_read_stdin && fclose (stdin) == EOF)
     die (_("close failed"), "-");