]> git.ipfire.org Git - thirdparty/valgrind.git/commitdiff
Add missing break for the DRM ioctl operations that do not have any args
authorPhilippe Waroquiers <philippe.waroquiers@skynet.be>
Sat, 11 Mar 2017 21:07:21 +0000 (21:07 +0000)
committerPhilippe Waroquiers <philippe.waroquiers@skynet.be>
Sat, 11 Mar 2017 21:07:21 +0000 (21:07 +0000)
Due to this missing break, the code was falling through to
the case VKI_SNDRV_CTL_IOCTL_PVERSION:
and was then setting some bytes as defined at (whatever address is in) ARG3.

Patch and analysis by Daniel Glöckner

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@16266

coregrind/m_syswrap/syswrap-linux.c

index 02fb127c712922ecd5f40a198e3f458197992575..bd6c3f2cca691222b47c2bd4c03e32209235db1b 100644 (file)
@@ -9520,6 +9520,8 @@ POST(sys_ioctl)
    case VKI_SNDRV_TIMER_IOCTL_STOP:
    case VKI_SNDRV_TIMER_IOCTL_CONTINUE:
    case VKI_SNDRV_TIMER_IOCTL_PAUSE:
+      break;
+
    case VKI_SNDRV_CTL_IOCTL_PVERSION: {
       POST_MEM_WRITE( (Addr)ARG3, sizeof(int) );
       break;