BUG/MINOR: lua/threads: Make lua's tasks sticky to the current thread

PiBa-NL reported a bug with tasks registered in lua when HAProxy is started with
serveral threads. These tasks have not specific affinity with threads so they
can be woken up on any threads. So, it is impossbile for these tasks to handled
cosockets or applets, because cosockets and applets are sticky on the thread
which created them. It is forbbiden to manipulate a cosocket from another
thread.

So to fix the bug, tasks registered in lua are now sticky to the current
thread. Because these tasks can be registered before threads creation, the
affinity is set the first time a lua's task is processed.

This patch must be backported in HAProxy 1.8.

diff --git a/src/hlua.c b/src/hlua.c
index da5611065f1c70469f183c5b7c2804fba690e3ae..32199c9640f72ea625e56f59e90556f9df411b1e 100644 (file)
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -5529,6 +5529,9 @@ static struct task *hlua_process_task(struct task *task)
        struct hlua *hlua = task->context;
        enum hlua_exec status;
 
+       if (task->thread_mask == MAX_THREADS_MASK)
+               task_set_affinity(task, tid_bit);
+
        /* If it is the first call to the task, we must initialize the
         * execution timeouts.
         */