]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: mwl8k: initialize cmd->addr[] properly
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 4 May 2024 11:38:15 +0000 (14:38 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:49:23 +0000 (09:49 +0200)
[ Upstream commit 1d60eabb82694e58543e2b6366dae3e7465892a5 ]

This loop is supposed to copy the mac address to cmd->addr but the
i++ increment is missing so it copies everything to cmd->addr[0] and
only the last address is recorded.

Fixes: 22bedad3ce11 ("net: convert multicast list to list_head")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/b788be9a-15f5-4cca-a3fe-79df4c8ce7b2@moroto.mountain
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/mwl8k.c

index 13bcb123d122347cc76f0aac3ed4ed2015d5c88c..c0ecd769ada76410ccddce28a763949c504142b8 100644 (file)
@@ -2718,7 +2718,7 @@ __mwl8k_cmd_mac_multicast_adr(struct ieee80211_hw *hw, int allmulti,
                cmd->action |= cpu_to_le16(MWL8K_ENABLE_RX_MULTICAST);
                cmd->numaddr = cpu_to_le16(mc_count);
                netdev_hw_addr_list_for_each(ha, mc_list) {
-                       memcpy(cmd->addr[i], ha->addr, ETH_ALEN);
+                       memcpy(cmd->addr[i++], ha->addr, ETH_ALEN);
                }
        }