]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ov9282: Correct the exposure offset
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Mon, 9 Dec 2024 14:55:45 +0000 (14:55 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:50:08 +0000 (12:50 +0100)
[ Upstream commit feaf4154d69657af2bf96e6e66cca794f88b1a61 ]

The datasheet lists that "Maximum exposure time is frame
length -25 row periods, where frame length is set by
registers {0x380E, 0x380F}".
However this driver had OV9282_EXPOSURE_OFFSET set to 12
which allowed that restriction to be violated, and would
result in very under-exposed images.

Correct the offset.

Fixes: 14ea315bbeb7 ("media: i2c: Add ov9282 camera sensor driver")
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/i2c/ov9282.c

index 2e0b315801e56605bf68682007df59778d513e4e..5bc9fafa72a4b10fcf88ed74a29dd7bccca42c3c 100644 (file)
@@ -31,7 +31,7 @@
 /* Exposure control */
 #define OV9282_REG_EXPOSURE    0x3500
 #define OV9282_EXPOSURE_MIN    1
-#define OV9282_EXPOSURE_OFFSET 12
+#define OV9282_EXPOSURE_OFFSET 25
 #define OV9282_EXPOSURE_STEP   1
 #define OV9282_EXPOSURE_DEFAULT        0x0282