]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
crypto: arm64/aes - Select CRYPTO_LIB_SHA256 from correct places
authorEric Biggers <ebiggers@kernel.org>
Mon, 12 Jan 2026 19:20:04 +0000 (11:20 -0800)
committerEric Biggers <ebiggers@kernel.org>
Mon, 12 Jan 2026 19:39:58 +0000 (11:39 -0800)
The call to sha256() occurs in code that is built when either
CRYPTO_AES_ARM64_CE_BLK or CRYPTO_AES_ARM64_NEON_BLK.  The option
CRYPTO_AES_ARM64 is unrelated, notwithstanding its documentation.  I'll
be removing CRYPTO_AES_ARM64 soon anyway, but before doing that, fix
where CRYPTO_LIB_SHA256 is selected from.

Fixes: 01834444d972 ("crypto: arm64/aes - use SHA-256 library instead of crypto_shash")
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20260112192035.10427-7-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
arch/arm64/crypto/Kconfig

index da1c9ea8ea83a89360800a6390f64b239e6d9ea1..4453dff8f0c13fd708930f5526eaf65337d4c457 100644 (file)
@@ -40,7 +40,6 @@ config CRYPTO_SM3_ARM64_CE
 config CRYPTO_AES_ARM64
        tristate "Ciphers: AES, modes: ECB, CBC, CTR, CTS, XCTR, XTS"
        select CRYPTO_AES
-       select CRYPTO_LIB_SHA256
        help
          Block ciphers: AES cipher algorithms (FIPS-197)
          Length-preserving ciphers: AES with ECB, CBC, CTR, CTS,
@@ -66,6 +65,7 @@ config CRYPTO_AES_ARM64_CE_BLK
        depends on KERNEL_MODE_NEON
        select CRYPTO_SKCIPHER
        select CRYPTO_AES_ARM64_CE
+       select CRYPTO_LIB_SHA256
        help
          Length-preserving ciphers: AES cipher algorithms (FIPS-197)
          with block cipher modes:
@@ -83,6 +83,7 @@ config CRYPTO_AES_ARM64_NEON_BLK
        depends on KERNEL_MODE_NEON
        select CRYPTO_SKCIPHER
        select CRYPTO_LIB_AES
+       select CRYPTO_LIB_SHA256
        help
          Length-preserving ciphers: AES cipher algorithms (FIPS-197)
          with block cipher modes: