]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:rpcsrv:samr: improve a comment in compare_msgRid
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Mon, 8 Apr 2024 10:55:50 +0000 (22:55 +1200)
committerJule Anger <janger@samba.org>
Mon, 10 Jun 2024 13:25:17 +0000 (13:25 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 6229feab74a734190c302ee9b1cc36960669743d)

source4/rpc_server/samr/dcesrv_samr.c

index ba5be53d8c9349d20ff4fa12a9a86c0a157c48cc..8faa457e80fb2dfd44b72653d50edcef4a60b25a 100644 (file)
@@ -1197,8 +1197,9 @@ static int compare_msgRid(struct ldb_message **m1, struct ldb_message **m2) {
        }
 
        /*
-        * Get and compare the rids, if we fail to extract a rid treat it as a
-        * missing SID and sort to the end of the list
+        * Get and compare the rids. If we fail to extract a rid (because
+        * there are no subauths) the msg goes to the end of the list, but
+        * before the NULL SIDs.
         */
        status = dom_sid_split_rid(NULL, sid1, NULL, &rid1);
        if (!NT_STATUS_IS_OK(status)) {