]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
daemon: decrease write errors severity in log
authorTomas Krizek <tomas.krizek@nic.cz>
Wed, 2 Sep 2020 12:32:21 +0000 (14:32 +0200)
committerTomas Krizek <tomas.krizek@nic.cz>
Tue, 13 Oct 2020 10:55:27 +0000 (12:55 +0200)
daemon/http.c
daemon/io.c
daemon/tls.c

index 96a16b6f9e6abc383c05c0c2f4ad338d4fdad2fe..9bd145e179c6b3a01e3adba64bbbb0feae5160ac 100644 (file)
@@ -387,7 +387,7 @@ ssize_t http_process_input_data(struct session *session, const uint8_t *in_buf,
 
        ret = nghttp2_session_send(ctx->h2);
        if (ret < 0) {
-               kr_log_error("[http] nghttp2_session_send failed: %s (%zd)\n",
+               kr_log_verbose("[http] nghttp2_session_send failed: %s (%zd)\n",
                             nghttp2_strerror(ret), ret);
                return kr_error(EIO);
        }
@@ -440,21 +440,21 @@ static int http_send_response(nghttp2_session *h2, char *size, size_t size_len,
 
        ret = nghttp2_submit_response(h2, stream_id, hdrs, sizeof(hdrs)/sizeof(*hdrs), prov);
        if (ret != 0) {
-               kr_log_error("[http] nghttp2_submit_response failed: %s\n", nghttp2_strerror(ret));
+               kr_log_verbose("[http] nghttp2_submit_response failed: %s\n", nghttp2_strerror(ret));
                on_pkt_write(data, kr_error(EIO));
                return kr_error(EIO);
        }
 
        ret = nghttp2_session_set_stream_user_data(h2, stream_id, (void*)data);
        if (ret != 0) {
-               kr_log_error("[http] failed to set stream user data: %s\n", nghttp2_strerror(ret));
+               kr_log_verbose("[http] failed to set stream user data: %s\n", nghttp2_strerror(ret));
                on_pkt_write(data, kr_error(EIO));
                return kr_error(EIO);
        }
 
        ret = nghttp2_session_send(h2);
        if(ret < 0) {
-               kr_log_error("[http] nghttp2_session_send failed: %s\n", nghttp2_strerror(ret));
+               kr_log_verbose("[http] nghttp2_session_send failed: %s\n", nghttp2_strerror(ret));
                return kr_error(EIO);
        }
 
index 8591df7e1025063499de6b947d3e9e8ab95c01cb..fda11d4f65dcd8b1877c723f1e6867f4bf2cfcf8 100644 (file)
@@ -347,6 +347,8 @@ static ssize_t tls_send(const uint8_t *buf, const size_t len, struct session *se
 
        sent = gnutls_record_send(ctx->c.tls_session, buf, len);
        if (sent < 0) {
+               kr_log_verbose("[http] gnutls_record_send failed: %s (%zd)\n",
+                              gnutls_strerror_name(sent), sent);
                return kr_error(EIO);
        }
        return sent;
index 43787f63ad6cc375bef29e92babd6dc4a93f3ece..89492837c894181c8403d31b07a26a07a4ccf947 100644 (file)
@@ -155,6 +155,8 @@ static ssize_t kres_gnutls_vec_push(gnutls_transport_ptr_t h, const giovec_t * i
                if (ret < 0 && ret != UV_EAGAIN) {
                        /* uv_try_write() has returned error code other then UV_EAGAIN.
                         * Return. */
+                       kr_log_verbose("[%s] uv_try_write error: %s\n",
+                                      t->client_side ? "tls_client" : "tls", uv_strerror(ret));
                        ret = -1;
                        errno = EIO;
                        return ret;
@@ -212,6 +214,8 @@ static ssize_t kres_gnutls_vec_push(gnutls_transport_ptr_t h, const giovec_t * i
                        t->write_queue_size += 1;
                } else {
                        free(p);
+                       kr_log_verbose("[%s] uv_write error: %s\n",
+                                      t->client_side ? "tls_client" : "tls", uv_strerror(ret));
                        errno = EIO;
                        ret = -1;
                }
@@ -405,8 +409,8 @@ int tls_write(uv_write_t *req, uv_handle_t *handle, knot_pkt_t *pkt, uv_write_cb
        ssize_t count = 0;
        if ((count = gnutls_record_send(tls_session, &pkt_size, sizeof(pkt_size)) < 0) ||
            (count = gnutls_record_send(tls_session, pkt->wire, pkt->size) < 0)) {
-               kr_log_error("[%s] gnutls_record_send failed: %s (%zd)\n",
-                            logstring, gnutls_strerror_name(count), count);
+               kr_log_verbose("[%s] gnutls_record_send failed: %s (%zd)\n",
+                              logstring, gnutls_strerror_name(count), count);
                return kr_error(EIO);
        }
 
@@ -417,8 +421,8 @@ int tls_write(uv_write_t *req, uv_handle_t *handle, knot_pkt_t *pkt, uv_write_cb
                if (!gnutls_error_is_fatal(ret)) {
                        return kr_error(EAGAIN);
                } else {
-                       kr_log_error("[%s] gnutls_record_uncork failed: %s (%d)\n",
-                                    logstring, gnutls_strerror_name(ret), ret);
+                       kr_log_verbose("[%s] gnutls_record_uncork failed: %s (%d)\n",
+                                      logstring, gnutls_strerror_name(ret), ret);
                        return kr_error(EIO);
                }
        }