Tweak error return value for acc_set_cuda_stream.

The return value of acc_set_cuda_stream is unspecified in OpenACC 2.6.
The testsuite changes might be unnecessary with the current async code.

	libgomp/
	* oacc-cuda.c (acc_set_cuda_stream): Return 0 on error/invalid
	arguments.
	* testsuite/libgomp.oacc-c-c++-common/lib-84.c: Handle unnumbered
	async stream being an alias for a numbered async stream.
	* testsuite/libgomp.oacc-c-c++-common/lib-85.c: Likewise.

diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp
index 15faa26336bfde79fd0893ab68831040e7320a44..a18e49aa572aa0fcbff1b382a1cfcbcd9c572ab1 100644 (file)
--- a/libgomp/ChangeLog.omp
+++ b/libgomp/ChangeLog.omp
@@ -1,3 +1,11 @@
+2019-02-12  Julian Brown <julian@codesourcery.com>
+
+       * oacc-cuda.c (acc_set_cuda_stream): Return 0 on error/invalid
+       arguments.
+       * testsuite/libgomp.oacc-c-c++-common/lib-84.c: Handle unnumbered
+       async stream being an alias for a numbered async stream.
+       * testsuite/libgomp.oacc-c-c++-common/lib-85.c: Likewise.
+
 2018-10-02  Thomas Schwinge  <thomas@codesourcery.com>
            Cesar Philippidis  <cesar@codesourcery.com>
 

diff --git a/libgomp/oacc-cuda.c b/libgomp/oacc-cuda.c
index 112fa1534960bc096e0be9cf39ab36f2c6a87bb4..cf8d4384de19c7b2cbe61de1b9a2399374bb5d16 100644 (file)
--- a/libgomp/oacc-cuda.c
+++ b/libgomp/oacc-cuda.c
@@ -115,6 +115,9 @@ acc_get_cuda_stream (int async)
   return ret;
 }
 
+/* As of OpenACC 2.6, the return code of this function appears to be
+   unspecified.  We choose to return 1 for success, or 0 for failure.  */
+
 int
 acc_set_cuda_stream (int async, void *stream)
 {
@@ -127,7 +130,7 @@ acc_set_cuda_stream (int async, void *stream)
 
   thr = goacc_thread ();
 
-  int ret = -1;
+  int ret = 0;
   if (thr && thr->dev && thr->dev->openacc.cuda.set_stream_func)
     {
       acc_prof_info prof_info;

diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-84.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-84.c
index d793c743630044bcdcfbbcdbbbb9e670ff724e4f..e2d86dee61c8fe9d11267ca26d80fe046badd7db 100644 (file)
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-84.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-84.c
@@ -38,6 +38,12 @@ main (int argc, char **argv)
       if (streams[i] != NULL)
        abort ();
 
+      /* The no-value async may be an alias for a numbered async stream.
+        Skip over setting it below else the above NULL check will fail for
+        the aliased stream.  */
+      if (i == acc_async_noval)
+       continue;
+
       r = cuStreamCreate (&streams[i], CU_STREAM_DEFAULT);
       if (r != CUDA_SUCCESS)
        {

diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-85.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-85.c
index 141c83b53dd69578823792c4f3a20f47772ee9b0..22982415d459b6140b2513db408bf31baa5b9e01 100644 (file)
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-85.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-85.c
@@ -38,6 +38,12 @@ main (int argc, char **argv)
       if (streams[i] != NULL)
        abort ();
 
+      /* The no-value async may be an alias for a numbered async stream.
+         Skip over setting it below else the above NULL check will fail for
+         the aliased stream.  */
+      if (i == acc_async_noval)
+       continue;
+
       r = cuStreamCreate (&streams[i], CU_STREAM_DEFAULT);
       if (r != CUDA_SUCCESS)
        {