Fix AIX SIGSEGV for multi thread debugging.

When we run threads debugging in AIX we get,

Reading symbols from //gdb_tests/continue-pending-status...
(gdb) r
Starting program: /gdb_tests/continue-pending-status

Program received signal SIGSEGV, Segmentation fault.
0x7fe00008 in ?? ()
(gdb) q
A debugging session is active.

The reason being in AIX, the __pthread_init symbol returned by pthdb_session_pthreaded() is a function descriptor
and not the the direct code address. When GDB set a breakpoint using ms.value_address(), it was setting the breakpoint on the descriptor itself (0xf16365dc) rather than the actual function code. This caused the program to crash at an invalid address (0x7fe00008) when trying to execute from the descriptor location.

Debugging further and looking at the history, GDB-17.1/GDB-17.2 knew __pthread_init was a function because STABS symbol was recored with proper type, so we knew it was a function descriptor. After STABS removal symbol is recoreded without type and ms.value_address() returns descriptor address directly.

if (cs->c_naux > 1 && ISFCN (cs->c_type))
      {
        fcn_start_addr = cs->c_value;
      }
case XMC_PR:
  /* A function entry point.  */

  record_minimal_symbol
    (reader, namestring, unrelocated_addr (symbol.n_value),
     sclass == C_HIDEXT ? mst_file_text : mst_text,
     symbol.n_scnum, objfile);
  misc_func_recorded = 1;
  break;

The code snippet above was one of the things STABS used to do that helped identify the entry point before.

This patch is the fix to the same.

Approved By: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>

diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
index 675d8d5070cda5665b7a85963fa6029958a777c5..5ac71d22237be555505a4372e8dc776c62342b41 100644 (file)
--- a/gdb/aix-thread.c
+++ b/gdb/aix-thread.c
@@ -974,7 +974,12 @@ pd_enable (inferior *inf)
     = lookup_minimal_symbol (current_program_space, stub_name);
   if (ms.minsym == NULL)
     return;
-  data->pd_brk_addr = ms.value_address ();
+
+  /* On AIX, symbols can be function descriptors, so we need to resolve
+     them to get the actual code address.  */
+  if (!msymbol_is_function (ms.objfile, ms.minsym, &data->pd_brk_addr))
+    return;
+
   if (!create_thread_event_breakpoint (current_inferior ()->arch (),
                                       data->pd_brk_addr))
     return;