]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
imsm: allow drives in a container regardless of sector size
authorAlexey Obitotskiy <aleksey.obitotskiy@intel.com>
Tue, 9 May 2017 10:25:43 +0000 (12:25 +0200)
committerJes Sorensen <jsorensen@fb.com>
Tue, 9 May 2017 18:17:50 +0000 (14:17 -0400)
IMSM doesn't allow to create arrays including drives with different
sector sizes. The initial idea was not to permit to combine drives
with different sector size in the same container. The problem is it
only worked for array creation. On array assemble there are no
calls to metadata handlers to see if drive is suitable for a container
(e.g. as a spare) and it leads to wrong configuration.

Revert the change and allow adding drives with different sector size
to the container.

Signed-off-by: Alexey Obitotskiy <aleksey.obitotskiy@intel.com>
Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
super-intel.c

index e13c9402a562d621489e8a19ef9a3b3dc629cb47..2a5d848f9e02f5b3a5d7f7e35b4e82058b50168f 100644 (file)
@@ -5716,12 +5716,6 @@ static int add_to_super_imsm(struct supertype *st, mdu_disk_info_t *dk,
        if (super->sector_size == 0) {
                /* this a first device, so sector_size is not set yet */
                super->sector_size = member_sector_size;
-       } else if (member_sector_size != super->sector_size) {
-               pr_err("Mixing between different sector size is forbidden, aborting...\n");
-               if (dd->devname)
-                       free(dd->devname);
-               free(dd);
-               return 1;
        }
 
        /* clear migr_rec when adding disk to container */