fix(query): fix empty query

diff --git a/__tests__/query.spec.js b/__tests__/query.spec.js
index fe561dbb34ba36c245bf3a6bb47b79ddfe073d19..47d3ad1090e1b3e2afea0d1b35810234f361ac60 100644 (file)
--- a/__tests__/query.spec.js
+++ b/__tests__/query.spec.js
@@ -15,4 +15,11 @@ describe('parseQuery', () => {
       foo: 'a',
     })
   })
+
+  it('works with an empty string', () => {
+    const emptyQuery = parseQuery('')
+    expect(Object.keys(emptyQuery)).toHaveLength(0)
+    expect(emptyQuery).toEqual({})
+    expect(parseQuery('?')).toEqual({})
+  })
 })

diff --git a/src/history/utils.ts b/src/history/utils.ts
index 70857fcd35a45df29cabaf5da5dc72dcce3b4b9d..3ad842632334085335d09cccae0b50a4671a48cd 100644 (file)
--- a/src/history/utils.ts
+++ b/src/history/utils.ts
@@ -54,6 +54,9 @@ export function parseURL(location: string): HistoryLocationNormalized {
 export function parseQuery(search: string): HistoryQuery {
   const hasLeadingIM = search[0] === '?'
   const query: HistoryQuery = {}
+  // avoid creating an object with an empty key and empty value
+  // because of split('&')
+  if (search === '' || search === '?') return query
   const searchParams = (hasLeadingIM ? search.slice(1) : search).split('&')
   for (let i = 0; i < searchParams.length; ++i) {
     const [key, value] = searchParams[i].split('=')