tools/coreutils: disable uninstall target

GNU coreutils is a unique case where we require
some of the utilities on the host machine
before anything is built.

The prerequisite is handled by symlinks to the host binaries
in the staging directory that are installed
by the build system and that are expected to remain
as long as the corresponding stampfile exists.

Because the binaries built by coreutils
will replace the symlinks, the uninstall target
will actually delete the symlinks
long before the build finishes whenever it is ran.

This can cause the utilities to be temporarily missing
from the controlled part of the shell's PATH,
so disable the removal of the coreutils utilities.
The appropriate way to clear all of the programs and links
would be `make dirclean`.

Tested-by: Georgi Valkov <gvalkov@gmail.com> # macOS
Signed-off-by: Michael Pratt <mcpratt@pm.me>
Link: https://github.com/openwrt/openwrt/pull/16522
Signed-off-by: Robert Marko <robimarko@gmail.com>

diff --git a/tools/coreutils/Makefile b/tools/coreutils/Makefile
index 42f03317d9f84987c5dbc369b42238c9d2630998..84aba9e64a886e96b20c43c3151225bbf509bcee 100644 (file)
--- a/tools/coreutils/Makefile
+++ b/tools/coreutils/Makefile
@@ -73,7 +73,7 @@ define Host/Install
 endef
 
 define Host/Uninstall
-       -$(call Host/Compile/Default,uninstall)
+       #$(call Host/Compile/Default,uninstall) # Removes necessary symlinks
        -$(call Host/Compile/Default,maintainer-clean) # Clean bootstrap files from the release
 endef