SAE: Use wpa_key_mgmt_sae() helper

Use the existing helper function instead of maintaining multiple copies
of lists of SAE key management suites.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>

diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index 78c0658a013232a97a6487daded7226c0458a517..7e72fc2aa507ff7ffed1f7a5ed11e44b465f2e04 100644 (file)
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -4834,8 +4834,7 @@ static int wpa_driver_nl80211_set_ap(void *priv,
 #endif /* CONFIG_IEEE80211AX */
 
 #ifdef CONFIG_SAE
-       if (((params->key_mgmt_suites & WPA_KEY_MGMT_SAE) ||
-            (params->key_mgmt_suites & WPA_KEY_MGMT_FT_SAE)) &&
+       if (wpa_key_mgmt_sae(params->key_mgmt_suites) &&
            nl80211_put_sae_pwe(msg, params->sae_pwe) < 0)
                goto fail;
 #endif /* CONFIG_SAE */
@@ -6389,8 +6388,7 @@ static int nl80211_connect_common(struct wpa_driver_nl80211_data *drv,
            nl80211_put_fils_connect_params(drv, params, msg) != 0)
                return -1;
 
-       if ((params->key_mgmt_suite == WPA_KEY_MGMT_SAE ||
-            params->key_mgmt_suite == WPA_KEY_MGMT_FT_SAE) &&
+       if (wpa_key_mgmt_sae(params->key_mgmt_suite) &&
            (!(drv->capa.flags & WPA_DRIVER_FLAGS_SME)) &&
            nla_put_flag(msg, NL80211_ATTR_EXTERNAL_AUTH_SUPPORT))
                return -1;
@@ -6440,8 +6438,7 @@ static int wpa_driver_nl80211_try_connect(
                goto fail;
 
 #ifdef CONFIG_SAE
-       if ((params->key_mgmt_suite == WPA_KEY_MGMT_SAE ||
-            params->key_mgmt_suite == WPA_KEY_MGMT_FT_SAE) &&
+       if (wpa_key_mgmt_sae(params->key_mgmt_suite) &&
            nl80211_put_sae_pwe(msg, params->sae_pwe) < 0)
                goto fail;
 #endif /* CONFIG_SAE */
@@ -6549,8 +6546,7 @@ static int wpa_driver_nl80211_associate(
 
                if (wpa_driver_nl80211_set_mode(priv, nlmode) < 0)
                        return -1;
-               if (params->key_mgmt_suite == WPA_KEY_MGMT_SAE ||
-                   params->key_mgmt_suite == WPA_KEY_MGMT_FT_SAE)
+               if (wpa_key_mgmt_sae(params->key_mgmt_suite))
                        bss->use_nl_connect = 1;
                else
                        bss->use_nl_connect = 0;

diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
index 5111297dcac100d1d92fa653675ec135dab69737..9ba4ae9c4463fc463b4eabaa1293df1db80e17ce 100644 (file)
--- a/wpa_supplicant/wpa_supplicant.c
+++ b/wpa_supplicant/wpa_supplicant.c
@@ -3089,7 +3089,7 @@ static u8 * wpas_populate_assoc_ies(
 #endif /* CONFIG_FILS */
 #endif /* IEEE8021X_EAPOL */
 #ifdef CONFIG_SAE
-       if (wpa_s->key_mgmt & (WPA_KEY_MGMT_SAE | WPA_KEY_MGMT_FT_SAE))
+       if (wpa_key_mgmt_sae(wpa_s->key_mgmt))
                algs = WPA_AUTH_ALG_SAE;
 #endif /* CONFIG_SAE */
 

diff --git a/wpa_supplicant/wpas_glue.c b/wpa_supplicant/wpas_glue.c
index d62914bc17d6f1bfeffc5cdbc87ddedebd36e186..ccc72c4d65f4e04f9f969ba23c494e863c0e4fd6 100644 (file)
--- a/wpa_supplicant/wpas_glue.c
+++ b/wpa_supplicant/wpas_glue.c
@@ -1312,7 +1312,7 @@ static void wpa_supplicant_transition_disable(void *_wpa_s, u8 bitmap)
 #ifdef CONFIG_SAE
        if ((bitmap & TRANSITION_DISABLE_WPA3_PERSONAL) &&
            wpa_key_mgmt_sae(wpa_s->key_mgmt) &&
-           (ssid->key_mgmt & (WPA_KEY_MGMT_SAE | WPA_KEY_MGMT_FT_SAE)) &&
+           wpa_key_mgmt_sae(ssid->key_mgmt) &&
            (ssid->ieee80211w != MGMT_FRAME_PROTECTION_REQUIRED ||
             (ssid->group_cipher & WPA_CIPHER_TKIP))) {
                wpa_printf(MSG_DEBUG,
@@ -1327,7 +1327,7 @@ static void wpa_supplicant_transition_disable(void *_wpa_s, u8 bitmap)
            wpa_s->sme.sae.state == SAE_ACCEPTED &&
            wpa_s->sme.sae.pk &&
 #endif /* CONFIG_SME */
-           (ssid->key_mgmt & (WPA_KEY_MGMT_SAE | WPA_KEY_MGMT_FT_SAE)) &&
+           wpa_key_mgmt_sae(ssid->key_mgmt) &&
            (ssid->sae_pk != SAE_PK_MODE_ONLY ||
             ssid->ieee80211w != MGMT_FRAME_PROTECTION_REQUIRED ||
             (ssid->group_cipher & WPA_CIPHER_TKIP))) {