]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
signal/stack: Remove redundant initialization
authorJeff Lucovsky <jeff@lucovsky.org>
Tue, 26 Apr 2022 18:46:06 +0000 (14:46 -0400)
committerVictor Julien <vjulien@oisf.net>
Wed, 27 Apr 2022 09:23:04 +0000 (11:23 +0200)
Ticket: 5228

This commit removes the redundant initialization of the stack-on-signal
functionality.

src/suricata.c

index ee0c9e9bcc102e2dc042ffd30294b2a462e4de9c..efdd2cc2981059f27c582bab19e3b9ac987fc5e7 100644 (file)
@@ -2005,27 +2005,6 @@ static int MayDaemonize(SCInstance *suri)
 /* Initialize the user and group Suricata is to run as. */
 static int InitRunAs(SCInstance *suri)
 {
-    /* registering signals we use */
-#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
-    UtilSignalHandlerSetup(SIGINT, SignalHandlerSigint);
-    UtilSignalHandlerSetup(SIGTERM, SignalHandlerSigterm);
-#if HAVE_LIBUNWIND
-    int enabled;
-    if (ConfGetBool("logging.stacktrace-on-signal", &enabled) == 0) {
-        enabled = 0;
-    }
-
-    if (enabled) {
-        SCLogInfo("Preparing unexpected signal handling");
-        struct sigaction stacktrace_action;
-        memset(&stacktrace_action, 0, sizeof(stacktrace_action));
-        stacktrace_action.sa_sigaction = SignalHandlerUnexpected;
-        stacktrace_action.sa_flags = SA_SIGINFO;
-        sigaction(SIGSEGV, &stacktrace_action, NULL);
-        sigaction(SIGABRT, &stacktrace_action, NULL);
-    }
-#endif /* HAVE_LIBUNWIND */
-#endif
 #ifndef OS_WIN32
     /* Try to get user/group to run suricata as if
        command line as not decide of that */