]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath9k: ahb: reorder declarations
authorRosen Penev <rosenp@gmail.com>
Mon, 9 Jun 2025 03:08:47 +0000 (20:08 -0700)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Thu, 26 Jun 2025 23:10:43 +0000 (16:10 -0700)
Easier to look at. Follows netdev style.

Also remove ret assignment. Because of all of these devm conversions,
ret = 0 is a path that never gets hit. The first time it does it when
request_irq fails, but that ends up reassigning it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Link: https://patch.msgid.link/20250609030851.17739-2-rosenp@gmail.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath9k/ahb.c

index 49b7ab26c477285fcfd219065734ec71b0e1269b..d2a97e74f451dd78a9ee8fb38655704896835aa2 100644 (file)
@@ -71,14 +71,14 @@ static const struct ath_bus_ops ath_ahb_bus_ops  = {
 
 static int ath_ahb_probe(struct platform_device *pdev)
 {
-       void __iomem *mem;
-       struct ath_softc *sc;
-       struct ieee80211_hw *hw;
        const struct platform_device_id *id = platform_get_device_id(pdev);
-       int irq;
-       int ret = 0;
+       struct ieee80211_hw *hw;
+       struct ath_softc *sc;
        struct ath_hw *ah;
+       void __iomem *mem;
        char hw_name[64];
+       int irq;
+       int ret;
 
        if (!dev_get_platdata(&pdev->dev)) {
                dev_err(&pdev->dev, "no platform data specified\n");