]> git.ipfire.org Git - thirdparty/xz.git/commitdiff
Avoid visibility related compiler warnings on Windows.
authorLasse Collin <lasse.collin@tukaani.org>
Wed, 1 Jul 2009 09:21:24 +0000 (12:21 +0300)
committerLasse Collin <lasse.collin@tukaani.org>
Wed, 1 Jul 2009 09:21:24 +0000 (12:21 +0300)
configure.ac

index b1961eca1f7da22db6adc9654d279fd4916d41fd..2f3af3d0ffec74c9530456b4e995b99eae5396c2 100644 (file)
@@ -554,21 +554,19 @@ lc_CPUCORES
 # If using GCC, set some additional AM_CFLAGS:
 ###############################################################################
 
-if test "x$GCC" = xyes ; then
+if test "$GCC" = yes ; then
        echo
        echo "GCC extensions:"
+fi
 
-       # Avoid checking for visibility support on Windows, because the test
-       # may succeed even though visibility isn't supported. Windows has
-       # a different way to export only the required symbols from the
-       # libraries.
-       if test "$is_w32" = no; then
-               gl_VISIBILITY
-               if test -n "$CFLAG_VISIBILITY" ; then
-                       AM_CFLAGS="$AM_CFLAGS $CFLAG_VISIBILITY"
-               fi
-       fi
+# Always do the visibility check but don't set AM_CFLAGS on Windows.
+# This way things get set properly even on Windows.
+gl_VISIBILITY
+if test -n "$CFLAG_VISIBILITY" && test "$is_w32" = no; then
+       AM_CFLAGS="$AM_CFLAGS $CFLAG_VISIBILITY"
+fi
 
+if test "$GCC" = yes ; then
        # Enable as much warnings as possible. These commented warnings won't
        # work for this package though:
        #   * -Wunreachable-code breaks several assert(0) cases, which are