]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
apparmor: don't overwrite error from reload_profile
authorJim Fehlig <jfehlig@suse.com>
Fri, 3 Feb 2017 02:17:29 +0000 (19:17 -0700)
committerJim Fehlig <jfehlig@suse.com>
Tue, 14 Feb 2017 23:53:30 +0000 (16:53 -0700)
Like other callers of reload_profile, don't overwrite errors in
AppArmorSetSecurityHostdevLabelHelper.

src/security/security_apparmor.c

index 2c33abb615ad512bb0138f603f5d1e0a98dd6b17..ad50b080827802b6d5cfec4bb40f2b15d479d6eb 100644 (file)
@@ -322,19 +322,7 @@ AppArmorSetSecurityHostdevLabelHelper(const char *file, void *opaque)
     struct SDPDOP *ptr = opaque;
     virDomainDefPtr def = ptr->def;
 
-    if (reload_profile(ptr->mgr, def, file, true) < 0) {
-        virSecurityLabelDefPtr secdef = virDomainDefGetSecurityLabelDef(
-                                                def, SECURITY_APPARMOR_NAME);
-        if (!secdef) {
-            virReportOOMError();
-            return -1;
-        }
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("cannot update AppArmor profile \'%s\'"),
-                       secdef->imagelabel);
-        return -1;
-    }
-    return 0;
+    return reload_profile(ptr->mgr, def, file, true);
 }
 
 static int