]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
utils: return default family when rtm_family is not RTNL_FAMILY_IPMR/IP6MR
authorHangbin Liu <liuhangbin@gmail.com>
Thu, 27 Jul 2017 09:44:15 +0000 (17:44 +0800)
committerStephen Hemminger <stephen@networkplumber.org>
Thu, 27 Jul 2017 18:27:17 +0000 (11:27 -0700)
When we get a multicast route, the rtm_type is RTN_MULTICAST, but the
rtm_family may be AF_INET. If we only check the type with RTNL_FAMILY_IPMR,
we will get malformed address. e.g.

+ ip -4 route add multicast 172.111.1.1 dev em1 table main

Before fix:
+ ip route list type multicast table main
multicast ac6f:101:800:400:400:0:3c00:0 dev em1 scope link

After fix:
+ ip route list type multicast table main
multicast 172.111.1.1 dev em1 scope link

Fixes: 56e3eb4c3400 ("ip: route: fix multicast route dumps")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Phil Sutter <phil@nwl.cc>
lib/utils.c

index e77bd302530bdc0d76e4963e26158d65ac50c516..9aa3219c5547dc3ecc832fb514657c067e4487a6 100644 (file)
@@ -1215,5 +1215,11 @@ int get_real_family(int rtm_type, int rtm_family)
        if (rtm_type != RTN_MULTICAST)
                return rtm_family;
 
-       return rtm_family == RTNL_FAMILY_IPMR ? AF_INET : AF_INET6;
+       if (rtm_family == RTNL_FAMILY_IPMR)
+               return AF_INET;
+
+       if (rtm_family == RTNL_FAMILY_IP6MR)
+               return AF_INET6;
+
+       return rtm_family;
 }