]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/chrome: chromeos_tbmc: Drop wakeup source on remove
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 5 Mar 2026 19:47:03 +0000 (20:47 +0100)
committerTzung-Bi Shih <tzungbi@kernel.org>
Fri, 6 Mar 2026 04:35:07 +0000 (04:35 +0000)
The wakeup source added by device_init_wakeup() in chromeos_tbmc_add()
needs to be dropped during driver removal, so add a .remove() callback
to the driver for this purpose.

Fixes: 0144c00ed86b ("platform/chrome: chromeos_tbmc: Report wake events")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://lore.kernel.org/r/6151957.MhkbZ0Pkbq@rafael.j.wysocki
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
drivers/platform/chrome/chromeos_tbmc.c

index d1cf8f3463ce3bc980666c7eb1ca5b2aac0b3533..e248567c0a18239ab2ebe5318722a1e9605d1fce 100644 (file)
@@ -95,6 +95,11 @@ static int chromeos_tbmc_add(struct acpi_device *adev)
        return 0;
 }
 
+static void chromeos_tbmc_remove(struct acpi_device *adev)
+{
+       device_init_wakeup(&adev->dev, false);
+}
+
 static const struct acpi_device_id chromeos_tbmc_acpi_device_ids[] = {
        { ACPI_DRV_NAME, 0 },
        { }
@@ -110,6 +115,7 @@ static struct acpi_driver chromeos_tbmc_driver = {
        .ids = chromeos_tbmc_acpi_device_ids,
        .ops = {
                .add = chromeos_tbmc_add,
+               .remove = chromeos_tbmc_remove,
                .notify = chromeos_tbmc_notify,
        },
        .drv.pm = &chromeos_tbmc_pm_ops,