]> git.ipfire.org Git - thirdparty/vuejs/core.git/commitdiff
test: fix unexpected warning check when asserting same message for both conditions
authorEvan You <yyx990803@gmail.com>
Fri, 9 Feb 2024 01:02:52 +0000 (09:02 +0800)
committerEvan You <yyx990803@gmail.com>
Fri, 9 Feb 2024 01:08:09 +0000 (09:08 +0800)
scripts/setup-vitest.ts

index d5c65f0d3c0b23672df0329d4e2351c9d7bf1fca..53e7f5fff569b5e995012430534c5cf036a6e077 100644 (file)
@@ -4,9 +4,9 @@ vi.stubGlobal('MathMLElement', class MathMLElement {})
 
 expect.extend({
   toHaveBeenWarned(received: string) {
-    asserted.add(received)
     const passed = warn.mock.calls.some(args => args[0].includes(received))
     if (passed) {
+      asserted.add(received)
       return {
         pass: true,
         message: () => `expected "${received}" not to have been warned.`,
@@ -25,10 +25,10 @@ expect.extend({
   },
 
   toHaveBeenWarnedLast(received: string) {
-    asserted.add(received)
     const passed =
       warn.mock.calls[warn.mock.calls.length - 1][0].includes(received)
     if (passed) {
+      asserted.add(received)
       return {
         pass: true,
         message: () => `expected "${received}" not to have been warned last.`,
@@ -44,7 +44,6 @@ expect.extend({
   },
 
   toHaveBeenWarnedTimes(received: string, n: number) {
-    asserted.add(received)
     let found = 0
     warn.mock.calls.forEach(args => {
       if (args[0].includes(received)) {
@@ -53,6 +52,7 @@ expect.extend({
     })
 
     if (found === n) {
+      asserted.add(received)
       return {
         pass: true,
         message: () => `expected "${received}" to have been warned ${n} times.`,