]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
vsock/test: Do not filter kallsyms by symbol type
authorMichal Luczaj <mhal@rbox.co>
Fri, 16 Jan 2026 08:52:36 +0000 (09:52 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 20 Jan 2026 15:45:39 +0000 (16:45 +0100)
Blamed commit implemented logic to discover available vsock transports by
grepping /proc/kallsyms for known symbols. It incorrectly filtered entries
by type 'd'.

For some kernel configs having

    CONFIG_VIRTIO_VSOCKETS=m
    CONFIG_VSOCKETS_LOOPBACK=y

kallsyms reports

    0000000000000000 d virtio_transport [vmw_vsock_virtio_transport]
    0000000000000000 t loopback_transport

Overzealous filtering might have affected vsock test suit, resulting in
insufficient/misleading testing.

Do not filter symbols by type. It never helped much.

Fixes: 3070c05b7afd ("vsock/test: Introduce get_transports()")
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://patch.msgid.link/20260116-vsock_test-kallsyms-grep-v1-1-3320bc3346f2@rbox.co
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
tools/testing/vsock/util.h

index 142c02a6834acb7117aca485b661332b73754b63..bf633cde82b073bf7f55553ff86be56b8e706488 100644 (file)
@@ -25,7 +25,7 @@ enum transport {
 };
 
 static const char * const transport_ksyms[] = {
-       #define x(name, symbol) "d " symbol "_transport",
+       #define x(name, symbol) " " symbol "_transport",
        KNOWN_TRANSPORTS(x)
        #undef x
 };