]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hrtimer: Fix trace oddity
authorThomas Gleixner <tglx@linutronix.de>
Mon, 19 Jan 2026 10:38:34 +0000 (11:38 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 22 Jan 2026 10:11:20 +0000 (11:11 +0100)
It turns out that __run_hrtimer() will trace like:

          <idle>-0     [032] d.h2. 20705.474563: hrtimer_cancel:       hrtimer=0xff2db8f77f8226e8
          <idle>-0     [032] d.h1. 20705.474563: hrtimer_expire_entry: hrtimer=0xff2db8f77f8226e8 now=20699452001850 function=tick_nohz_handler/0x0

Which is a bit nonsensical, the timer doesn't get canceled on
expiration. The cause is the use of the incorrect debug helper.

Fixes: c6a2a1770245 ("hrtimer: Add tracepoint for hrtimers")
Reported-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260121143208.219595606@infradead.org
kernel/time/hrtimer.c

index f8ea8c8fc89529889ab3a4d0a9acaec872856c85..d8935ab10a2fd1d7cd0a5c717b36ad089303d7ea 100644 (file)
@@ -1742,7 +1742,7 @@ static void __run_hrtimer(struct hrtimer_cpu_base *cpu_base,
 
        lockdep_assert_held(&cpu_base->lock);
 
-       debug_deactivate(timer);
+       debug_hrtimer_deactivate(timer);
        base->running = timer;
 
        /*