CVE-2019-3824 ldb: Improve code style and layout in wildcard processing

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/lib/ldb/common/ldb_match.c b/lib/ldb/common/ldb_match.c
index 9af558c7b891b6c71e6e10eb89305bf7bbeeffd8..fc1d6001a19b8318795d4e7e570f6612d544befc 100644 (file)
--- a/lib/ldb/common/ldb_match.c
+++ b/lib/ldb/common/ldb_match.c
@@ -333,9 +333,11 @@ static int ldb_wildcard_compare(struct ldb_context *ldb,
 
                                g = memmem(haystack,
                                           haystacklen,
-                                       (const uint8_t *)cnk.data,
-                                       cnk.length);
-                               if (g) p = g;
+                                          (const uint8_t *)cnk.data,
+                                          cnk.length);
+                               if (g) {
+                                       p = g;
+                               }
                        } while(g);
                }
                val.length = val.length - (p - (uint8_t *)(val.data)) - cnk.length;