]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
cpufreq: Remove duplicate check in __cpufreq_offline()
authorLifeng Zheng <zhenglifeng1@huawei.com>
Mon, 23 Jun 2025 13:33:59 +0000 (21:33 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 14 Jul 2025 17:38:10 +0000 (19:38 +0200)
The has_target() checks in __cpufreq_offline() are duplicate.

Remove one of them and put the operations of exiting governor together
with storing last governor's name.

Signed-off-by: Lifeng Zheng <zhenglifeng1@huawei.com>
Link: https://patch.msgid.link/20250623133402.3120230-5-zhenglifeng1@huawei.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index 5560c7df03475b440aba853a46feb42774720f12..6ea39181e832221830110ba265e1c334ab4f9d9b 100644 (file)
@@ -1691,14 +1691,13 @@ static void __cpufreq_offline(unsigned int cpu, struct cpufreq_policy *policy)
                return;
        }
 
-       if (has_target())
+       if (has_target()) {
                strscpy(policy->last_governor, policy->governor->name,
                        CPUFREQ_NAME_LEN);
-       else
-               policy->last_policy = policy->policy;
-
-       if (has_target())
                cpufreq_exit_governor(policy);
+       } else {
+               policy->last_policy = policy->policy;
+       }
 
        /*
         * Perform the ->offline() during light-weight tear-down, as