]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath5k: Use max() to improve code
authorQianfeng Rong <rongqianfeng@vivo.com>
Tue, 15 Jul 2025 12:16:48 +0000 (20:16 +0800)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Tue, 15 Jul 2025 16:17:15 +0000 (09:17 -0700)
Use max() to reduce the code and improve its readability.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Link: https://patch.msgid.link/20250715121721.266713-3-rongqianfeng@vivo.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath5k/phy.c

index 4825f9cb9cb8573aa4eb2305a24eba64180b0a1b..66b2dee391559e004857a297eb2f4f46e96fd982 100644 (file)
@@ -3116,10 +3116,7 @@ ath5k_combine_pwr_to_pdadc_curves(struct ath5k_hw *ah,
                                                        pd_gain_overlap;
 
                /* Force each power step to be at least 0.5 dB */
-               if ((pdadc_tmp[1] - pdadc_tmp[0]) > 1)
-                       pwr_step = pdadc_tmp[1] - pdadc_tmp[0];
-               else
-                       pwr_step = 1;
+               pwr_step = max(pdadc_tmp[1] - pdadc_tmp[0], 1);
 
                /* If pdadc_0 is negative, we need to extrapolate
                 * below this pdgain by a number of pwr_steps */
@@ -3144,11 +3141,8 @@ ath5k_combine_pwr_to_pdadc_curves(struct ath5k_hw *ah,
                        continue;
 
                /* Force each power step to be at least 0.5 dB */
-               if ((pdadc_tmp[table_size - 1] - pdadc_tmp[table_size - 2]) > 1)
-                       pwr_step = pdadc_tmp[table_size - 1] -
-                                               pdadc_tmp[table_size - 2];
-               else
-                       pwr_step = 1;
+               pwr_step = max(pdadc_tmp[table_size - 1] -
+                              pdadc_tmp[table_size - 2], 1);
 
                /* Extrapolate above */
                while ((pdadc_0 < (s16) pdadc_n) &&