s4:rpc_server: Check return code of cli_credentials_set_conf()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/rpc_server/remote/dcesrv_remote.c b/source4/rpc_server/remote/dcesrv_remote.c
index 7a362d6b3af5d2302046238f98b7d352bb09eb06..a57f2a75f3e7cf4d748576a9a56cf13b0ceb0bb8 100644 (file)
--- a/source4/rpc_server/remote/dcesrv_remote.c
+++ b/source4/rpc_server/remote/dcesrv_remote.c
@@ -120,13 +120,21 @@ static NTSTATUS remote_get_private(struct dcesrv_call_state *dce_call,
        credentials = dcesrv_call_credentials(dce_call);
 
        if (user && pass) {
+               bool ok;
+
                DEBUG(5, ("dcerpc_remote: RPC Proxy: Using specified account\n"));
                credentials = cli_credentials_init(priv);
                if (!credentials) {
                        return NT_STATUS_NO_MEMORY;
                }
                must_free_credentials = true;
-               cli_credentials_set_conf(credentials, dce_call->conn->dce_ctx->lp_ctx);
+
+               ok = cli_credentials_set_conf(credentials,
+                                             dce_call->conn->dce_ctx->lp_ctx);
+               if (!ok) {
+                       return NT_STATUS_INTERNAL_ERROR;
+               }
+
                cli_credentials_set_username(credentials, user, CRED_SPECIFIED);
                if (domain) {
                        cli_credentials_set_domain(credentials, domain, CRED_SPECIFIED);