]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: Fix memory leak when free'ing virDomainObj
authorLuke Yue <lukedyue@gmail.com>
Tue, 10 Aug 2021 13:47:21 +0000 (21:47 +0800)
committerPavel Hrdina <phrdina@redhat.com>
Tue, 10 Aug 2021 13:55:55 +0000 (15:55 +0200)
Free dom->deprecations when free'ing virDomainObj

Signed-off-by: Luke Yue <lukedyue@gmail.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
src/conf/domain_conf.c

index 3415e28b959373971e43109c5eef4022ce6d6f32..15452ef6fcc2591f91f135c5b80c42d867fff430 100644 (file)
@@ -3730,6 +3730,16 @@ void virDomainDefFree(virDomainDef *def)
     g_free(def);
 }
 
+static void
+virDomainObjDeprecationFree(virDomainObj *dom)
+{
+    size_t i = 0;
+    for (i = 0; i < dom->ndeprecations; i++) {
+        g_free(dom->deprecations[i]);
+    }
+    g_free(dom->deprecations);
+}
+
 static void virDomainObjDispose(void *obj)
 {
     virDomainObj *dom = obj;
@@ -3742,6 +3752,7 @@ static void virDomainObjDispose(void *obj)
     if (dom->privateDataFreeFunc)
         (dom->privateDataFreeFunc)(dom->privateData);
 
+    virDomainObjDeprecationFree(dom);
     virDomainSnapshotObjListFree(dom->snapshots);
     virDomainCheckpointObjListFree(dom->checkpoints);
 }