]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
of: reserved_mem: Fix placement of __free() annotation
authorGregory CLEMENT <gregory.clement@bootlin.com>
Wed, 7 Jan 2026 13:04:52 +0000 (14:04 +0100)
committerRob Herring (Arm) <robh@kernel.org>
Wed, 4 Feb 2026 02:58:12 +0000 (20:58 -0600)
The __free() annotation was incorrectly placed before the variable
name instead of after it, which resulted in the following checkpatch
errors:

ERROR: need consistent spacing around '*' (ctx:WxV)
+       struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);
                                               ^
WARNING: function definition argument 'idx' should also have an identifier name
+       struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);

As part of this cleanup, also remove the useless return statement
flagged by checkpatch.

Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Link: https://patch.msgid.link/20260107-mtd-memregion-v3-1-f9fc9107b992@bootlin.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/of/of_reserved_mem.c

index 5619ec9178587123f93779184236009d2e9942ac..1ab8f4153600b274438f8e59a17a3d80454e0953 100644 (file)
@@ -127,7 +127,6 @@ static void __init fdt_reserved_mem_save_node(unsigned long node, const char *un
        fdt_init_reserved_mem_node(rmem);
 
        reserved_mem_count++;
-       return;
 }
 
 static int __init early_init_dt_reserve_memory(phys_addr_t base,
@@ -747,7 +746,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
        if (!np)
                return -EINVAL;
 
-       struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);
+       struct device_node *target __free(device_node) = of_parse_phandle(np, "memory-region", idx);
        if (!target || !of_device_is_available(target))
                return -ENODEV;