]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: iwlwifi: mld: eliminate duplicate WIDE_ID in PPAG command handling
authorPagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>
Fri, 20 Mar 2026 08:09:11 +0000 (10:09 +0200)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Wed, 25 Mar 2026 09:31:57 +0000 (11:31 +0200)
Extract the PER_PLATFORM_ANT_GAIN_CMD command ID into a local variable
to avoid duplicating WIDE_ID(PHY_OPS_GROUP, PER_PLATFORM_ANT_GAIN_CMD).

Signed-off-by: Pagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20260320100746.7b7e6315e2cc.Icffcc47ac1e876708b6219a89fd546a018797d44@changeid
drivers/net/wireless/intel/iwlwifi/mld/regulatory.c

index 2486d78d6fc38e41bf17c2c8a2f543ea0de8f503..f91f61ca9b2e6cb1d8ab164670231fb70e0fbd35 100644 (file)
@@ -211,10 +211,8 @@ static int iwl_mld_ppag_send_cmd(struct iwl_mld *mld)
                .v8.ppag_config_info.hdr.table_revision = fwrt->ppag_bios_rev,
                .v8.ppag_config_info.value = cpu_to_le32(fwrt->ppag_flags),
        };
-       int cmd_ver =
-               iwl_fw_lookup_cmd_ver(mld->fw,
-                                     WIDE_ID(PHY_OPS_GROUP,
-                                             PER_PLATFORM_ANT_GAIN_CMD), 1);
+       u32 cmd_id = WIDE_ID(PHY_OPS_GROUP, PER_PLATFORM_ANT_GAIN_CMD);
+       int cmd_ver = iwl_fw_lookup_cmd_ver(mld->fw, cmd_id, 1);
        int cmd_len = sizeof(cmd.v8);
        int ret;
 
@@ -271,9 +269,7 @@ static int iwl_mld_ppag_send_cmd(struct iwl_mld *mld)
        }
 
        IWL_DEBUG_RADIO(mld, "Sending PER_PLATFORM_ANT_GAIN_CMD\n");
-       ret = iwl_mld_send_cmd_pdu(mld, WIDE_ID(PHY_OPS_GROUP,
-                                               PER_PLATFORM_ANT_GAIN_CMD),
-                                  &cmd, cmd_len);
+       ret = iwl_mld_send_cmd_pdu(mld, cmd_id, &cmd, cmd_len);
        if (ret < 0)
                IWL_ERR(mld, "failed to send PER_PLATFORM_ANT_GAIN_CMD (%d)\n",
                        ret);