]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: atomisp: Use the actual value of the enum instead of the enum
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 2 Dec 2024 15:47:16 +0000 (15:47 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 5 May 2025 07:47:27 +0000 (09:47 +0200)
hrt_isp_css_irq_sw_pin_0 has a different enum type than
irq_sw_channel_id_t.

Replace it with the actual value of hrt_isp_css_irq_sw_pin_0 to avoid
arithmetic operations between different enum types (and make the
compiler happy).

It is required to build with llvm 19 without these warnings:
.../sh_css_hrt.c:68:19: warning: arithmetic between different enumeration types ('irq_sw_channel_id_t' and 'enum hrt_isp_css_irq') [-Wenum-enum-conversion]
.../sh_css.c:1233:40: warning: arithmetic between different enumeration types ('irq_sw_channel_id_t' and 'enum hrt_isp_css_irq') [-Wenum-enum-conversion]
.../sh_css.c:1237:40: warning: arithmetic between different enumeration types ('irq_sw_channel_id_t' and 'enum hrt_isp_css_irq') [-Wenum-enum-conversion]

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Link: https://lore.kernel.org/r/20241202-fix-llvm9-v1-2-2a50f5acfd0b@chromium.org
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/hive_isp_css_common/irq_global.h

index 2c47e7820bd7555e2debf282ad949b61849abbb7..69e68ecd6bc380f37d190bfbee254216cf9aaeb4 100644 (file)
@@ -18,7 +18,7 @@
 #endif
 
 /* The IRQ is not mapped uniformly on its related interfaces */
-#define        IRQ_SW_CHANNEL_OFFSET   hrt_isp_css_irq_sw_pin_0
+#define        IRQ_SW_CHANNEL_OFFSET   HIVE_GP_DEV_IRQ_SW_PIN_0_BIT_ID
 
 typedef enum {
        IRQ_SW_CHANNEL0_ID = hrt_isp_css_irq_sw_pin_0 - IRQ_SW_CHANNEL_OFFSET,