pinctrl: realtek: Simplify error handling with dev_err_probe()

Convert the error handling code in probe() to use dev_err_probe() to
enhance semantic meaning.

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>

diff --git a/drivers/pinctrl/realtek/pinctrl-rtd.c b/drivers/pinctrl/realtek/pinctrl-rtd.c
index 56fd3093c20683eaa6bc80e9f226c31259fb8978..382bdae54bf33e333d9497d3f1f63566cb8b63e0 100644 (file)
--- a/drivers/pinctrl/realtek/pinctrl-rtd.c
+++ b/drivers/pinctrl/realtek/pinctrl-rtd.c
@@ -566,15 +566,14 @@ int rtd_pinctrl_probe(struct platform_device *pdev, const struct rtd_pinctrl_des
        data->regmap_pinctrl = devm_regmap_init_mmio(data->dev, data->base,
                                                     &rtd_pinctrl_regmap_config);
 
-       if (IS_ERR(data->regmap_pinctrl)) {
-               dev_err(data->dev, "failed to init regmap: %ld\n",
-                       PTR_ERR(data->regmap_pinctrl));
-               return PTR_ERR(data->regmap_pinctrl);
-       }
+       if (IS_ERR(data->regmap_pinctrl))
+               return dev_err_probe(data->dev, PTR_ERR(data->regmap_pinctrl),
+                                    "Failed to init regmap\n");
 
        data->pcdev = devm_pinctrl_register(&pdev->dev, &data->desc, data);
        if (IS_ERR(data->pcdev))
-               return PTR_ERR(data->pcdev);
+               return dev_err_probe(data->dev, PTR_ERR(data->pcdev),
+                                    "Failed to register pinctrl\n");
 
        platform_set_drvdata(pdev, data);